-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add multiple env support #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoxyFarhad
commented
Dec 18, 2025
RoxyFarhad
commented
Dec 18, 2025
RoxyFarhad
commented
Dec 18, 2025
RoxyFarhad
commented
Dec 18, 2025
5927953 to
f2e47c5
Compare
RoxyFarhad
commented
Dec 18, 2025
e2aa69e to
5259f20
Compare
RoxyFarhad
commented
Dec 18, 2025
2f8c94b to
7881ec2
Compare
c55c9e4 to
0c3a8c2
Compare
RoxyFarhad
commented
Dec 22, 2025
RoxyFarhad
commented
Dec 22, 2025
RoxyFarhad
commented
Dec 22, 2025
RoxyFarhad
commented
Dec 22, 2025
smoreinis
approved these changes
Dec 23, 2025
aeeb44f to
9939a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new naming convention to support multiple environment deployments:
Why we need this distinction:
env-namethat is the same as the deployment target (i.e. anenv-nameofdevand a deployment targetdev) it will automatically deploy to that environment.This supports the desired config change of having different environments that map to a single "environment":
Backwards compatability:
Tests against internal scale agents:
N.B. There was a large diff generated by linter for some reason